Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/importer-rest-api-specs: adding Common IDs for App Service / App Service Plan / App Service Environment #2816

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jul 25, 2023

Needs the associated Common IDs into hashicorp/go-azure-helpers vendored into hashicorp/go-azure-sdk and hashicorp/terraform-provider-azurerm first

Dependent on hashicorp/go-azure-helpers#172

@tombuildsstuff tombuildsstuff added the area/resource-ids Related to Resource IDs, Parsers and Formatters label Jul 25, 2023
@tombuildsstuff tombuildsstuff self-assigned this Jul 25, 2023
@tombuildsstuff tombuildsstuff marked this pull request as ready for review September 1, 2023 14:06
@tombuildsstuff tombuildsstuff requested a review from a team September 1, 2023 14:08
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

This can be merged after the next hashicorp/go-azure-sdk release

@tombuildsstuff tombuildsstuff merged commit 922c659 into main Sep 6, 2023
1 check passed
@tombuildsstuff tombuildsstuff deleted the f/common-ids-for-app-service branch September 6, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resource-ids Related to Resource IDs, Parsers and Formatters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants